Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] feat: 채팅 알림에 모임 정보(모임 사진, 모임 이름) 추가 #706

Closed
wants to merge 5 commits into from
Closed

[BE] feat: 채팅 알림에 모임 정보(모임 사진, 모임 이름) 추가 #706

wants to merge 5 commits into from

Conversation

takoyakimchi
Copy link
Contributor

@takoyakimchi takoyakimchi commented Oct 23, 2024 •
edited
Loading

이슈

개발 사항

  • 아래 이미지와 같이, 모임 이미지와 모임 제목을 알림에 추가했습니다.
  • dev 서버에서 클라이언트 작동 확인 완료입니다.
    image

@takoyakimchi takoyakimchi added the 🖥 backend backend label Oct 23, 2024
@takoyakimchi takoyakimchi added this to the Sprint6 milestone Oct 23, 2024
@takoyakimchi takoyakimchi self-assigned this Oct 23, 2024
@takoyakimchi takoyakimchi changed the title [BE] feat: 채팅 알림에 모임 정보(사진 URL, 모임 이름) 추가 [BE] feat: 채팅 알림에 모임 정보(모임 사진, 모임 이름) 추가 Oct 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit da16e1d.

♻️ This comment has been updated with latest results.

@takoyakimchi
Copy link
Contributor Author

테스트 수정하여 다시 요청드립니다.

테스트 실패하던 이유: 채팅방에 들어가거나 채팅방에서 나갈 때, 알림을 보내고 있다.
알림을 보낼 때 기존에는 모임 정보가 필요 없었지만, 현재는 모임 정보를 추가하였다.
테스트 코드는 모임을 고려하지 않고 작성되어 있어서, 테스트가 실패하고 있었다.

ehtjsv2
ehtjsv2 previously approved these changes Oct 23, 2024
View reviewed changes
jimi567
jimi567 previously approved these changes Oct 23, 2024
View reviewed changes
@takoyakimchi takoyakimchi dismissed stale reviews from jimi567 and ehtjsv2 via da16e1d October 23, 2024 10:45
@takoyakimchi takoyakimchi deleted the feature/#704 branch November 4, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehtjsv2 ehtjsv2 ehtjsv2 left review comments

@jimi567 jimi567 jimi567 left review comments

@J-I-H-O J-I-H-O Awaiting requested review from J-I-H-O J-I-H-O is a code owner

Assignees

@takoyakimchi takoyakimchi

Labels
🖥 backend backend
Projects
2024-friendogly
Status: Done
Milestone
Sprint6
Development

Successfully merging this pull request may close these issues.

채팅 알림에 제목 및 모임 사진 추가
3 participants
@takoyakimchi @jimi567 @ehtjsv2