[BE] multiDataSource 설정 수정 및 테스트 검증 강화 #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimi567
requested review from
ehtjsv2,
J-I-H-O and
takoyakimchi
as code owners
Closed
Test Results221 tests 221 ✅ 17s ⏱️ Results for commit 080ec1e. ♻️ This comment has been updated with latest results. |
takoyakimchi
approved these changes
Oct 23, 2024
ehtjsv2
previously approved these changes
Oct 23, 2024
J-I-H-O
previously approved these changes
Oct 23, 2024
takoyakimchi
requested changes
Oct 23, 2024
Comment on lines
28
to
31
| @Bean(name = "dataSource") | ||
| public DataSource dataSource(@Qualifier(ROUTING_DATA_SOURCE) DataSource routingDataSourceType) throws SQLException { | ||
| return new LazyConnectionDataSourceProxy(routingDataSourceType); | ||
| } |
There was a problem hiding this comment.
Suggested change
| @Bean(name = "dataSource") | |
| public DataSource dataSource(@Qualifier(ROUTING_DATA_SOURCE) DataSource routingDataSourceType) throws SQLException { | |
| return new LazyConnectionDataSourceProxy(routingDataSourceType); | |
| } | |
| @Bean(name = "dataSource") | |
| public DataSource dataSource(@Qualifier(ROUTING_DATA_SOURCE) DataSource routingDataSourceType) { | |
| return new LazyConnectionDataSourceProxy(routingDataSourceType); | |
| } |
Co-authored-by: TRE <[email protected]>
J-I-H-O
approved these changes
Oct 23, 2024
takoyakimchi
approved these changes
Oct 23, 2024
takoyakimchi
added a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: TRE <[email protected]> Co-authored-by: ehtjsv2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항