[BE] fix: 이미지 용량 제한을 5MB로 설정 #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takoyakimchi
requested review from
ehtjsv2,
jimi567 and
J-I-H-O
as code owners
Test Results196 tests 196 ✅ 17s ⏱️ Results for commit 706efc2. ♻️ This comment has been updated with latest results. |
jinuemong
reviewed
Oct 11, 2024
| @@ -29,7 +29,7 @@ | |||
| public class S3StorageManager implements FileStorageManager { | |||
|
|
|||
| private static final String IMAGE_MIME_TYPE_PREFIX = "image/"; | |||
| private static final int FILE_SIZE_LIMIT = 1; | |||
| private static final int FILE_SIZE_LIMIT = 5; | |||
jimi567
previously approved these changes
Oct 14, 2024
Comment on lines
2
to
5
| servlet: | ||
| multipart: | ||
| max-file-size: 6MB | ||
| max-request-size: 6MB |
There was a problem hiding this comment.
multipart단에서 터지면 예외메시지가 불친절하게 나옵니다
There was a problem hiding this comment.
헉 근데 15MB 이래버리면 어차피 nginx에서 터지네요.. 필요 없을것같기도 하고
There was a problem hiding this comment.
가장 바깥 단에서 막을 수도 있는걸 의도적으로 비즈니스 코드까지 들어오도록 허용하는게 최선인지는 잘 모르겠습니다 🥸
ehtjsv2
previously approved these changes
Oct 14, 2024
J-I-H-O
approved these changes
Oct 14, 2024
ehtjsv2
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
전달 사항 (없으면 삭제해 주세요)