[BE] feat: 놀이터 등록, 전체 놀이터 위치 조회 API 구현 #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehtjsv2
requested review from
jimi567,
J-I-H-O and
takoyakimchi
as code owners
Closed
4 tasks
Test Results196 tests 196 ✅ 18s ⏱️ Results for commit 081a3bf. ♻️ This comment has been updated with latest results. |
takoyakimchi
requested changes
Oct 4, 2024
Comment on lines
77
to
81
| @GetMapping("/exists/mine") | ||
| public ApiResponse<FindExistMyPetResponse> existMine(@Auth Long memberId) { | ||
| FindExistMyPetResponse response = petQueryService.existMine(memberId); | ||
| return ApiResponse.ofSuccess(response); | ||
| } |
There was a problem hiding this comment.
Suggested change
| @GetMapping("/exists/mine") | |
| public ApiResponse<FindExistMyPetResponse> existMine(@Auth Long memberId) { | |
| FindExistMyPetResponse response = petQueryService.existMine(memberId); | |
| return ApiResponse.ofSuccess(response); | |
| } | |
| @GetMapping("/exists/mine") | |
| public ApiResponse<FindPetExistenceResponse> checkPetExistence(@Auth Long memberId) { | |
| FindPetExistenceResponse response = petQueryService.checkPetExistence(memberId); | |
| return ApiResponse.ofSuccess(response); | |
| } |
existMine은 어색한 것 같아요. 네이밍 제안해봅니다~
Comment on lines
94
to
96
|
|
||
| @DisplayName("멤버가 가진 펫이 한마리라도 있는 지 알 수 있다 : False") | ||
| @Test |
There was a problem hiding this comment.
Suggested change
| @DisplayName("멤버가 가진 펫이 한마리라도 있는 지 알 수 있다 : False") | |
| @Test | |
| @DisplayName("멤버가 가진 펫이 한마리라도 있는 지 알 수 있다 : True") | |
| @Test |
jimi567
previously approved these changes
Oct 6, 2024
…course-teams/2024-friendogly into feature/be-playground-post
jimi567
previously approved these changes
Oct 9, 2024
J-I-H-O
requested changes
Oct 10, 2024
J-I-H-O
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
리뷰 요청 사항
https://github.com/woowacourse-teams/2024-friendogly/pull/607/files/793eaee1c21b5108812281ae8444d8e013d4a76e..ab7e50632397faa3e2aa8288a4553e4fa09c6016
전달 사항