[FE] 최종 데모데이 이후 발견된 버그들을 수정한다. #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng-ggood into fix/939-bugs-after-final
skiende74
approved these changes
Nov 10, 2024
| export const article = { | ||
| import { Article } from '@/types/article'; | ||
|
|
||
| export const article: Article = { |
skiende74
reviewed
Nov 10, 2024
Comment on lines
+27
to
30
| const handleClickAddress = () => { | ||
| loadExternalScriptWithCallback('daumAddress', openPostcodeEmbed); | ||
| openModal(); | ||
| }; |
There was a problem hiding this comment.
이건 주소모달 안떠서 새로고침해야 되던 에러를 잡은 건가요?
There was a problem hiding this comment.
네 혹시 랜더링 되기 전에 모달이 떠서 그런걸까 라는 생각에 진행했습니다만 사실 개발 환경에서는 모달 내에서 주소가 안뜬 적이 없어서 정확히 파악하기가 쉽지 않았네요..
healim01
temporarily deployed
to
frontend-msw
GitHub Actions
Inactive
|
@skiende74 지하 층수 버그가 initalValue 가 바뀌더라도 드롭다운이 재랜더가 안되어서 문제더라구요! 내부에 useEffect 로 Inital 달라지면 변경해주게 작업해놨습니다~! |
ooherin
reviewed
Nov 12, 2024
Comment on lines
+27
to
30
| const handleClickAddress = () => { | ||
| loadExternalScriptWithCallback('daumAddress', openPostcodeEmbed); | ||
| openModal(); | ||
| }; |
| import roomInfoStore from '@/store/roomInfoStore'; | ||
| import useSelectedOptionStore from '@/store/useSelectedOptionStore'; | ||
|
|
||
| const useResetChecklist = () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
버그 수정 완료
확인 불가한 오류,,
📢 논의하고 싶은 내용
🎸 기타