Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
구글 태그 및 채널톡 버튼 추가, 코드리뷰 마감시간 알림 슬랙봇 구현 #496
구글 태그 및 채널톡 버튼 추가, 코드리뷰 마감시간 알림 슬랙봇 구현 #496
Changes from 6 commits
df80245
9c0e880
bab8ba0
9d654d4
235f726
315a54d
fb1c91f
249aa51
27a055c
dbdd10b
d34a51f
caed48f
8f392d7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
필요한 출력인지 궁금합니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그냥 궁금한건데 이 deadline을 선언하는 곳이 없는데 어떻게 사용 가능한가요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
조건문의 조건의 가독성을 올려보시는 것을 제안해봅니다 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 위 조건이 잘 이해가 안되는데ㅠㅠ
정리된 경우의 수가
이렇게 네 가지 케이스로 볼 수 있을 것 같아요!
여기서 오늘/내일이란 말을 없애고 그냥 월/일/요일로 작성하면 더 가독성있고, 코드 경우의 수도 줄어들 것 같은데 어떠신가요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
생각해보니까 오늘/내일 때문에 더 복잡해진거였네요😅😅
제안 감사합니다! 반영해서 새로운 pr로 다시 올릴게요~
(새로운 pr을 다시 올려야 github actions이 제대로 작동하는지 확인해볼 수 있어서..😂)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id는 숨기지 않아도 괜찮나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
플러그인 키는 숨기지 않아도 괜찮은 키인가요?