Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/#657: Swiper 0.9.4 버전 적용 #658

Merged
merged 3 commits into from
Jul 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"@tanstack/react-query-devtools": "^5.17.9",
"axios": "^1.5.1",
"history": "^5.3.0",
"map-befine-swiper": "^0.8.3",
"map-befine-swiper": "^0.9.4",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-ga4": "^2.1.0",
Expand Down
12 changes: 1 addition & 11 deletions frontend/src/components/Banner/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,7 @@ export default function Banner() {
};

return (
<Swiper
as="section"
width={1140}
height={400}
$simpleTab
$tabBoxPosition="bottom"
$isNotTabBoxShow
swipeable
swiper
autoplay
>
<Swiper tag="section" width={1140} height="auto" $tabBoxPosition="bottom" autoplay>
<Tab label="붕어빵 지도">
<Box cursor="pointer" onClick={goToBoongABbangTopic}>
<BannerImage
Expand Down
18 changes: 3 additions & 15 deletions frontend/src/components/PinImageContainer/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,7 @@ function PinImageContainer({ images, getPinData }: PinImageContainerProps) {
$errorDefaultSrc={NOT_FOUND_IMAGE}
/>
</div>
<RemoveImageIconWrapper
onClick={() => onRemovePinImage(image.id)}
>
<RemoveImageIconWrapper onClick={() => onRemovePinImage(image.id)}>
<RemoveImageButton />
</RemoveImageIconWrapper>
</ImageWrapper>
Expand All @@ -84,15 +82,7 @@ function PinImageContainer({ images, getPinData }: PinImageContainerProps) {

return (
<Wrapper>
<Swiper
as="ul"
width={330}
height={100}
$elementsOneTab={3}
swiper
swipeable
$isNotTabBoxShow
>
<Swiper tag="ul" width={330} height={100} $slidePerTab={3}>
{images.map((image, index) => (
<Tab label={`${index}`} key={image.id}>
<ImageWrapper key={`image-${index}`}>
Expand All @@ -105,9 +95,7 @@ function PinImageContainer({ images, getPinData }: PinImageContainerProps) {
$errorDefaultSrc={NOT_FOUND_IMAGE}
/>
</div>
<RemoveImageIconWrapper
onClick={() => onRemovePinImage(image.id)}
>
<RemoveImageIconWrapper onClick={() => onRemovePinImage(image.id)}>
<RemoveImageButton />
</RemoveImageIconWrapper>
</ImageWrapper>
Expand Down
31 changes: 11 additions & 20 deletions frontend/src/components/TopicCardContainer/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,22 +30,11 @@ function TopicCardContainer({
<section>
<Flex $justifyContent="space-between" $alignItems="flex-end">
<Box>
<MediaText
as="h2"
color="black"
$fontSize="extraLarge"
$fontWeight="bold"
tabIndex={0}
>
<MediaText as="h2" color="black" $fontSize="extraLarge" $fontWeight="bold" tabIndex={0}>
{containerTitle}
</MediaText>
<Space size={0} />
<MediaText
color="gray"
$fontSize="default"
$fontWeight="normal"
tabIndex={0}
>
<MediaText color="gray" $fontSize="default" $fontWeight="normal" tabIndex={0}>
{containerDescription}
</MediaText>
</Box>
Expand All @@ -68,14 +57,16 @@ function TopicCardContainer({
<Space size={4} />

<Swiper
as="ul"
tag="ul"
width={1140}
height={300}
$elementsOneTab={5}
$elementsMediaQueries={[1180, 900, 660, 320]}
swiper
swipeable
$isNotTabBoxShow
height="auto"
$slidePerTab={5}
$breakPoints={{
1100: 4,
900: 3,
660: 2,
320: 1,
}}
>
{topics &&
topics.map(
Expand Down
4 changes: 0 additions & 4 deletions frontend/webpack.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ const path = require('path');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const { ProvidePlugin, DefinePlugin } = require('webpack');
const DotenvWebpackPlugin = require('dotenv-webpack');
const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer');
const CompressionPlugin = require('compression-webpack-plugin');

module.exports = {
Expand All @@ -29,9 +28,6 @@ module.exports = {
new DotenvWebpackPlugin({
systemvars: true,
}),
new BundleAnalyzerPlugin({
openAnalyzer: false,
}),
new CompressionPlugin({
filename: '[path][base].gz',
algorithm: 'gzip',
Expand Down
Loading