[로또] 신민준 미션 제출합니다. #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| private fun checkBuyAmount(buyAmount: String): Boolean { |
There was a problem hiding this comment.
뷰 안에서 너무 많은 역할을 담당할 수 있으니, 이렇게 체킹하는 함수는 따로 validator 같은 파일로 분리하는 게 관리하기 좋을 것 같아요!🙂🙂
There was a problem hiding this comment.
아하! 확실히 분리하는 게 용도도 명확해보여서 더 좋은 것 같습니다! 감사합니다!
| } | ||
| } | ||
|
|
||
|
|
||
| // TODO: 추가 기능 구현에 따른 테스트 코드 작성 |
There was a problem hiding this comment.
컨트롤러의 함수나 유효성 검사 기능을 담당하는 코드에 대한 추가 테스트 코드가 있으면 좋을 거 같아요.
There was a problem hiding this comment.
제가 테스트 코드 작성이 조금 미숙해서... 이번 미션에서 한번 추가해보겠습니다!
|
|
||
| object Constant { | ||
| const val INPUT_BUY_MESSAGE = "구입금액을 입력해 주세요." | ||
| const val LOTTO_PRICE = 1000 |
There was a problem hiding this comment.
로또 가격까지 상수화 하셨군요! 전 이 부분은 생각 못했네요👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 기능