-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use curl
instead of cr
#289
base: main
Are you sure you want to change the base?
Conversation
Compared to cr its really unreadable 🙈 whats the current issue with the latest cr release? Just stick with the working version for now if its a known bug? |
Well, Personally, I'd drop the gh-pages upload entirely. So: either somebody else commits to maintain |
@@ -7,26 +7,21 @@ when: | |||
|
|||
steps: | |||
pack-chart: | |||
image: quay.io/helmpack/chart-releaser:v1.7.0 | |||
image: alpine/helm:3.16.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not an official image from the alpine maintainers. Dont know how trustworthy the author is.
|
||
release-chart: | ||
image: quay.io/helmpack/chart-releaser:v1.7.0 | ||
image: alpine:3.21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be full qualified container name.
Fiddling around with jq curl and json input is also error prone and Im using cr across multiple repos without such issues. But at the end I dont care much, if you think this process is more stable. |
@pat-s I see you reverted cr. If you addressed the open comments here, we could also merge this PR. |
To get the release published successfully. I couldn't ensure that the release will work with this PR as I didn't test it on a test repo explicitly. I'll implement a related process in a new repo with write access soon and it seemed overall safer to me to proceed this way with the latest release. I'll leave it up to you to continue here/decide what to do. |
More issues than help. Broke again after the most recent
1.7
release when releasing chart 2.0.4.A
curl
command to upload to create a GH release directly should be more resilient.