Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GitHub Action workflow to run QIT E2E Integration tests. #2897

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

iamdharmesh
Copy link
Member

Issue: #2723


Description

This PR adds a GitHub Action workflow to run QIT E2E integration tests for each pull request. The tests are located in the integration tests repository, and this action will trigger the test run on every pull request.

Note: Repository secrets need to be set to run this GitHub Action workflow.

Steps to Test

Make sure that QIT E2E tests GitHub action is running and passing on this PR. (This is PR from fork repo so, This GH action will not successfully run here, you can verify it from PR here)

Documentation

  • This PR needs documentation (has the "Documentation" label).

Changelog Entry

Dev - Add a GitHub Action workflow to run QIT E2E Integration tests.

Closes #2723

@vikrampm1
Copy link

@dkotter checking if we need a Woo review on this PR?

@dkotter
Copy link

dkotter commented Dec 13, 2024

@dkotter checking if we need a Woo review on this PR?

Yes, Woo should review this to ensure they're okay with the approach

@vikrampm1
Copy link

@woocommerce/quark this PR is ready for your review! We don't have permissions to request review so tagging you here.

@jeffpaul
Copy link

@diegocurbelo can you help update this PR so that it properly gets into your team's review queue?

@Mayisha Mayisha self-requested a review December 19, 2024 05:49
@Mayisha
Copy link
Contributor

Mayisha commented Dec 19, 2024

Code looks good. I will add the secrets to run the tests.

@iamdharmesh iamdharmesh marked this pull request as ready for review December 23, 2024 09:14
@jeffpaul
Copy link

@iamdharmesh looks like some sort of failure in the e2e run to check on?

@iamdharmesh
Copy link
Member Author

@iamdharmesh looks like some sort of failure in the e2e run to check on?

@jeffpaul it's due to repo secrets are not set yet. (Also, as this PR is from the forked repo, secres won't be available for this PR even after adding it)

@jeffpaul
Copy link

jeffpaul commented Jan 3, 2025

@iamdharmesh can't someone with maintain or admin rights grant the PR access to use those secrets?

@Mayisha can you confirm the secrets have been added?

@iamdharmesh
Copy link
Member Author

@iamdharmesh can't someone with maintain or admin rights grant the PR access to use those secrets?

@jeffpaul I am not aware if any possible way for this. I have raised parallel PR on my forked repo and action is passing there. Therefore, once we confirm that secrets are added we are good to merge this.

@Mayisha
Copy link
Contributor

Mayisha commented Jan 6, 2025

@Mayisha can you confirm the secrets have been added?

@jeffpaul I have not added the secrets to this repository yet. Let's keep the merging of this PR on hold for now.
For now, we will run the QIT integration tests (for both Stripe and PayPal) on each PR in the Stripe repository. The Stripe PR has been merged today. We will incorporate monitoring and updating them to the Stripe plugin processes first.

@diegocurbelo diegocurbelo removed the request for review from Mayisha January 16, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add QIT E2E Integrations Tests
5 participants