Handle crash in Bulk Order Update when item position is -1

[hafizrahman]

Closes: #13358

Description

I can't reproduce the issue reported in the linked Sentry issue. The docs for getBindingAdapterPosition says:

The adapter position of the item if it still exists in the adapter. NO_POSITION if item has been removed from the adapter, notifyDataSetChanged has been called after the last layout pass or the ViewHolder has already been recycled.

Nevertheless, since it's a possibility that viewHolder.bindingAdapterPosition returns RecyclerView.NO_POSITION which is equal to -1, this PR adds handling for that by simply returning null when that happens. This makes the selection not happen on the item with no position, but it won't crash anymore.

Steps to reproduce

Since I'm not sure how to test the issue, it's probably good to smoke test the bulk update order feature to ensure that it still works after this PR.

Testing information

n/a

The tests that have been performed

Smoke-tested the feature to ensure it still works with the changes in this PR.

Images/gif

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

[dangermattic]

	1 Warning
⚠️	This PR is assigned to the milestone 21.4 ❄️. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	2d4a970
	Direct Download	woocommerce-wear-prototype-build-pr13359-2d4a970.apk

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	2d4a970
	Direct Download	woocommerce-prototype-build-pr13359-2d4a970.apk

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 40.80%. Comparing base (438ecaf) to head (2d4a970).
Report is 2 commits behind head on release/21.4.

Files with missing lines	Patch %	Lines
...ce/android/ui/orders/DefaultOrderListItemLookup.kt	0.00%	9 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##             release/21.4   #13359   +/-   ##
===============================================
  Coverage           40.80%   40.80%           
  Complexity           6411     6411           
===============================================
  Files                1353     1353           
  Lines               77679    77678    -1     
  Branches            10692    10692           
===============================================
  Hits                31698    31698           
+ Misses              43172    43171    -1     
  Partials             2809     2809           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hichamboushaba]

Changes look good and make sense, I tested the feature and didn't notice any regression, thanks for the quick fix @hafizrahman