-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update screenshot device mockup #13249
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this following the p2 documentation:
bundle exec fastlane take_screenshots locales:en-US
worked flawlessly the first time- Installed the dependencies:
brew install imagemagick automattic/build-tools/drawText
bundle install --with screenshots
bundle exec fastlane download_promo_strings
bundle exec fastlane create_promo_screenshots
also worked flawlessly the first time
This created the promo screenshots correctly, and the new device frames look correct too. It's just that it has issues with corners, except for the top left corner, as well as the camera cutout in the center:
I see you don't have the same issues on your screenshots, so it feels like it's something specific with my build. Comparing my screenshot to yours, what's obvious is that the font size in mine is much bigger than yours. Could this be the cause?
Sorry @hafizrahman ! I forgot to mention that the emulator needs to be a Pixel 9 XL. |
Discussed this in Slack; looks great now using the same emulator dimension! I did not know that the script uses whatever is the current active emulator 👍🏼 |
Closes: woocommerce/woomobile-private#398
Description
This updates device mockup on the promo screenshots.
Steps to reproduce
Follow Android Screenshots instructions (P91TBi-8Pt-p2) to test generating promo screenshots.
The tests that have been performed
Generated promo screenshots with
bundle exec fastlane create_promo_screenshot locales:en-US
Images/gif
Ignore status bar icons since I didn't enable demo mode when capturing screenshots.
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: