Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screenshot device mockup #13249

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Update screenshot device mockup #13249

merged 5 commits into from
Jan 7, 2025

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Jan 6, 2025

Closes: woocommerce/woomobile-private#398

Description

This updates device mockup on the promo screenshots.

Steps to reproduce

Follow Android Screenshots instructions (P91TBi-8Pt-p2) to test generating promo screenshots.

The tests that have been performed

Generated promo screenshots with bundle exec fastlane create_promo_screenshot locales:en-US

Images/gif

Ignore status bar icons since I didn't enable demo mode when capturing screenshots.

Before After
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@irfano irfano added the Releases Used in release management. Using this label will skip some bot checks. label Jan 6, 2025
@irfano irfano requested a review from hichamboushaba January 6, 2025 19:41
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR has the Releases label: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 6, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit9630124
Direct Downloadwoocommerce-wear-prototype-build-pr13249-9630124.apk

@irfano irfano removed the request for review from hichamboushaba January 6, 2025 20:03
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 6, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit9630124
Direct Downloadwoocommerce-prototype-build-pr13249-9630124.apk

@irfano irfano marked this pull request as ready for review January 6, 2025 20:32
@hafizrahman hafizrahman self-assigned this Jan 7, 2025
Copy link
Contributor

@hafizrahman hafizrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this following the p2 documentation:

  1. bundle exec fastlane take_screenshots locales:en-US worked flawlessly the first time
  2. Installed the dependencies:
    1. brew install imagemagick automattic/build-tools/drawText
    2. bundle install --with screenshots
    3. bundle exec fastlane download_promo_strings
  3. bundle exec fastlane create_promo_screenshots also worked flawlessly the first time

This created the promo screenshots correctly, and the new device frames look correct too. It's just that it has issues with corners, except for the top left corner, as well as the camera cutout in the center:

Pixel 9-02 Pixel 9-03
Pixel 9-05 Pixel 9-04
Pixel 9-01

I see you don't have the same issues on your screenshots, so it feels like it's something specific with my build. Comparing my screenshot to yours, what's obvious is that the font size in mine is much bigger than yours. Could this be the cause?

@irfano
Copy link
Contributor Author

irfano commented Jan 7, 2025

Sorry @hafizrahman ! I forgot to mention that the emulator needs to be a Pixel 9 XL.

@hafizrahman
Copy link
Contributor

hafizrahman commented Jan 7, 2025

Sorry @hafizrahman ! I forgot to mention that the emulator needs to be a Pixel 9 XL.

Discussed this in Slack; looks great now using the same emulator dimension! I did not know that the script uses whatever is the current active emulator 👍🏼

@hafizrahman hafizrahman merged commit 3cb2f4c into trunk Jan 7, 2025
15 checks passed
@hafizrahman hafizrahman deleted the update-screenshot-mockup branch January 7, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Releases Used in release management. Using this label will skip some bot checks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants