-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update icon colors #13242
Update icon colors #13242
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/woo-2.0-brand-updates #13242 +/- ##
================================================================
Coverage 40.59% 40.59%
Complexity 6372 6372
================================================================
Files 1345 1345
Lines 77235 77235
Branches 10602 10602
================================================================
Hits 31352 31352
Misses 43135 43135
Partials 2748 2748 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand testing isn't necessary but I did check in some places to confirm in dark mode. Good to go 👍🏼
Closes: woocommerce/woomobile-private#402
Description
color/primary
, allowing the icons to adapt to the dark theme. For example, the color will be Purple 40 in light mode and Purple 30 in dark mode. Some of our icons already support this.Steps to reproduce
Testing isn’t really necessary since this PR only adjusts the tone of purple.
Testing information
The tests that have been performed
I haven't tested all icons in the app since these changes only affect the purple color.
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: