Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icon colors #13242

Merged

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Jan 4, 2025

Closes: woocommerce/woomobile-private#402

Description

  • This updates the purple color in single-color icons.
  • Replaces hardcoded colors in vector icons with color/primary, allowing the icons to adapt to the dark theme. For example, the color will be Purple 40 in light mode and Purple 30 in dark mode. Some of our icons already support this.
  • Removes unused single-color icons.

Steps to reproduce

Testing isn’t really necessary since this PR only adjusts the tone of purple.

Testing information

The tests that have been performed

I haven't tested all icons in the app since these changes only affect the purple color.

Images/gif

Before After
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@irfano irfano added the category: design Layout and style elements in the UI or user interface, including color and animations. label Jan 4, 2025
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitc1cde94
Direct Downloadwoocommerce-wear-prototype-build-pr13242-c1cde94.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitc1cde94
Direct Downloadwoocommerce-prototype-build-pr13242-c1cde94.apk

WooCommerce/src/main/res/drawable/info.xml Dismissed Show dismissed Hide dismissed
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 40.59%. Comparing base (cd796aa) to head (c1cde94).
Report is 36 commits behind head on feature/woo-2.0-brand-updates.

Files with missing lines Patch % Lines
...i/products/selector/components/SelectorListItem.kt 0.00% 3 Missing ⚠️
...rce/android/ui/compose/component/SelectionCheck.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##             feature/woo-2.0-brand-updates   #13242   +/-   ##
================================================================
  Coverage                            40.59%   40.59%           
  Complexity                            6372     6372           
================================================================
  Files                                 1345     1345           
  Lines                                77235    77235           
  Branches                             10602    10602           
================================================================
  Hits                                 31352    31352           
  Misses                               43135    43135           
  Partials                              2748     2748           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hafizrahman hafizrahman self-assigned this Jan 6, 2025
Copy link
Contributor

@hafizrahman hafizrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand testing isn't necessary but I did check in some places to confirm in dark mode. Good to go 👍🏼

@hafizrahman hafizrahman merged commit 320cc86 into feature/woo-2.0-brand-updates Jan 6, 2025
15 checks passed
@hafizrahman hafizrahman deleted the feature/update-icon-colors branch January 6, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants