-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shipping Labels Revamp] Add Package template loading and recovery feedback #13236
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13236 +/- ##
============================================
- Coverage 40.64% 40.63% -0.02%
+ Complexity 6387 6385 -2
============================================
Files 1351 1351
Lines 77444 77449 +5
Branches 10650 10655 +5
============================================
- Hits 31479 31469 -10
- Misses 43186 43200 +14
- Partials 2779 2780 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, Thomaz. Nice touch enabling continued flow when the package saving fails.
LGTM!
…oading-feedback # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/wooshippinglabels/packages/WooShippingLabelPackageCreationViewModel.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/wooshippinglabels/packages/datasource/FetchPredefinedPackagesFromStore.kt
Why
As it is, the current Package Selection flow handles a Custom package being saved as a template as an optimistic operation, but after some team discussions, we decided to keep direct feedback to the user to allow them to know if it failed or not.
How
This PR introduces not only loading feedback for the Custom package creation but also an Error dialog that suggests the user use the package without saving it as a template if the problem persists as a quick solution for any custom package creation unavailability on the store.
Screen Capture
Error Handling
Screen_recording_20250102_194433.mp4
Loading feedback
Screen_recording_20250102_200127.mp4
How to Test
Scenario 1 - Loading feedback
Scenario 2 - No Loading feedback
Scenario 3 - Error handling
WooShippingLabelPackageRepository.createCustomPackage
function to the following:Proceed
button and verify that the Package is selected to the Shipping Labels formUpdate release notes:
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: