-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address selection #13235
Address selection #13235
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13235 +/- ##
============================================
- Coverage 40.64% 40.62% -0.03%
+ Complexity 6387 6386 -1
============================================
Files 1351 1351
Lines 77444 77500 +56
Branches 10650 10655 +5
============================================
+ Hits 31479 31486 +7
- Misses 43186 43234 +48
- Partials 2779 2780 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great UI work, @atorresveiga! Looks good
Part of: #12439
Description
This PR updates the ship from selection control to use a bottom sheet dialog. The changes focus only on UI changes and minor adjustments to prepare the view model to save the bottom sheets' state. A different PR will tackle full support for keeping the bottom sheets' state.
Testing information
Prerequisites
TC1
TC2
TC3
The tests that have been performed
Images/gif
Screen_recording_20250102_182922.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: