-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WCRemoveButton
for Actions Like "Remove Coupon" and "Remove Discount"
#13229
base: trunk
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13229 +/- ##
============================================
- Coverage 40.64% 40.63% -0.02%
+ Complexity 6387 6386 -1
============================================
Files 1351 1351
Lines 77444 77472 +28
Branches 10650 10663 +13
============================================
- Hits 31479 31478 -1
- Misses 43186 43214 +28
- Partials 2779 2780 +1 ☔ View full report in Codecov by Sentry. |
Closes: #12686 and #12685
Description
This PR introduces a new composable button,
WCRemoveButton
, designed for actions such as "Remove coupon" and "Remove discount." The button is visually styled to convey its purpose, featuring a red border and text, and supports optional leading and trailing icons for better contextual representation.Steps to reproduce
Testing information
The tests that have been performed
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: