Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS][Non-Simple Products] Remove variation quantity in Products and Variations screen #13225

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

AnirudhBhat
Copy link
Contributor

Closes: #13221

Description

This PR removes variation quantity in Products and Variations screen. Since we are filtering some of the variations client side and the variation quantity in the products endpoint includes all the variation. It's error prone to display the exact amount of variation a variable product contains after client side filtering (this filtering happens in the variations screen).

For this reasons, we decided to display "Options available" instead of variation quantity in products screen and remove variation quantity from the toolbar in variations screen.

More context: pdfdoF-62l-p2#comment-7224

Steps to reproduce

Products screen

  1. Navigate to POS (More menu -> POS)
  2. Ensure you see "Options available" instead of variation quantity on a variable product

Variations screen

  1. Navigate to POS (More menu -> POS)
  2. Ensure you do not see variation quantity in the toolbar

The tests that have been performed

Tested both the screens on both light and dark mode

Images/gif

variation_quantity_removed.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@AnirudhBhat AnirudhBhat added type: task An internally driven task. feature: point of sale POS project labels Dec 31, 2024
@AnirudhBhat AnirudhBhat added this to the 21.4 milestone Dec 31, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit3f54acc
Direct Downloadwoocommerce-wear-prototype-build-pr13225-3f54acc.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit3f54acc
Direct Downloadwoocommerce-prototype-build-pr13225-3f54acc.apk

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 40.64%. Comparing base (6f99cb6) to head (3f54acc).
Report is 21 commits behind head on trunk.

Files with missing lines Patch % Lines
...ce/android/ui/woopos/home/items/WooPosItemsList.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #13225   +/-   ##
=========================================
  Coverage     40.64%   40.64%           
  Complexity     6380     6380           
=========================================
  Files          1349     1349           
  Lines         77400    77400           
  Branches      10647    10647           
=========================================
  Hits          31461    31461           
  Misses        43159    43159           
  Partials       2780     2780           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnirudhBhat AnirudhBhat requested a review from samiuelson January 2, 2025 04:11
@AnirudhBhat AnirudhBhat marked this pull request as ready for review January 2, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: point of sale POS project type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS][Non-Simple Products] Remove variation quantity in both products and variations screen
3 participants