-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds tracking to site visibility editing #13223
base: issue/13213-disable-notifications-api-request
Are you sure you want to change the base?
Adds tracking to site visibility editing #13223
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
…ue/13222-site-visibility-tracking
….com/woocommerce/woocommerce-android into issue/13222-site-visibility-tracking
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## issue/13213-disable-notifications-api-request #13223 +/- ##
===================================================================================
+ Coverage 40.65% 40.67% +0.01%
- Complexity 6386 6390 +4
===================================================================================
Files 1351 1351
Lines 77474 77492 +18
Branches 10653 10657 +4
===================================================================================
+ Hits 31500 31518 +18
Misses 43192 43192
Partials 2782 2782 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, all good in my tests with Simulator API 34. 🚢
trunk
Closes: #13222
Description
Adds tracking to edit site's visibility feature.
Steps to reproduce
Testing information
🔵 Tracked: woocommerceandroid_site_picker_edit_button_shown
Edit Stores
cta an verify the following is shown🔵 Tracked: woocommerceandroid_site_picker_edit_button_tapped,
Save
. Check the following is tracked:🔵 Tracked: woocommerceandroid_site_picker_list_save_button_tapped, Properties: {"hidden_site_count":2
Error tracking
🔵 Tracked: woocommerceandroid_site_picker_list_saving_failure, Properties: {"error":"ApiError(message=)"
The tests that have been performed
The above.
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: