Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HACK][Order Refund] Partial refund inconsistency #13212

Merged

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Dec 27, 2024

Closes: #12964

Description

Order -> refund -> We show all the items, including those that were refunded already. That PR fixes that

Steps to reproduce

  • Create an order with a few products in it
  • Refund some of the products
  • Start refund process again
  • Notice that all the products are shown, including those that were refunded

Testing information

Use the steps above

The tests that have been performed

Steps above

Images/gif

01-08--10-07.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov linked an issue Dec 27, 2024 that may be closed by this pull request
@kidinov kidinov marked this pull request as draft December 27, 2024 14:01
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 27, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit9248970
Direct Downloadwoocommerce-wear-prototype-build-pr13212-9248970.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 27, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit9248970
Direct Downloadwoocommerce-prototype-build-pr13212-9248970.apk

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.67%. Comparing base (3cb2f4c) to head (9248970).
Report is 46 commits behind head on trunk.

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13212      +/-   ##
============================================
+ Coverage     40.64%   40.67%   +0.02%     
- Complexity     6393     6396       +3     
============================================
  Files          1351     1351              
  Lines         77616    77621       +5     
  Branches      10675    10677       +2     
============================================
+ Hits          31548    31571      +23     
+ Misses        43285    43260      -25     
- Partials       2783     2790       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kidinov kidinov added this to the 21.4 milestone Jan 8, 2025
@kidinov kidinov requested a review from samiuelson January 8, 2025 09:10
@kidinov kidinov added the type: bug A confirmed bug. label Jan 8, 2025
@kidinov kidinov changed the title [Order Refund] Partial refund inconsistency [HACK][Order Refund] Partial refund inconsistency Jan 8, 2025
@kidinov kidinov marked this pull request as ready for review January 8, 2025 09:11
@samiuelson samiuelson self-assigned this Jan 8, 2025
Copy link
Collaborator

@samiuelson samiuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samiuelson samiuelson merged commit 6b7781f into trunk Jan 8, 2025
16 of 18 checks passed
@samiuelson samiuelson deleted the 12964-mobile-payments-partial-refund-inconsistency branch January 8, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mobile Payments] Partial refund inconsistency
4 participants