-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS][Non-Simple Products] Handle empty state on variation screen #13209
base: trunk
Are you sure you want to change the base?
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13209 +/- ##
============================================
- Coverage 40.59% 40.57% -0.02%
- Complexity 6364 6365 +1
============================================
Files 1345 1345
Lines 77238 77267 +29
Branches 10601 10604 +3
============================================
- Hits 31353 31350 -3
- Misses 43128 43159 +31
- Partials 2757 2758 +1 ☔ View full report in Codecov by Sentry. |
…ull to be shown as well
Closes: #13206
Description
This PR
Decision: pdfdoF-62l-p2#comment-7224
Steps to reproduce
Variable products with no variations published
Variable products with no variations
The tests that have been performed
Tested the above scenario by disabling variations both from the app and from the admin page.
Images/gif
variations_empty_state.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: