Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tap To Pay] Remove first TTP usage survey #13207

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Dec 26, 2024

Closes: #12992

Description

The PR reviews the request of the TTP survey

Testing information

  • More -> Payments
  • Notice there is no usage survey request
  • Validate that there is no code left overs

The tests that have been performed

Above

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov linked an issue Dec 26, 2024 that may be closed by this pull request
@kidinov kidinov requested a review from samiuelson December 26, 2024 09:41
@kidinov kidinov added this to the 21.4 milestone Dec 26, 2024
@kidinov kidinov added the feature: mobile payments Related to mobile payments / card present payments / Woo Payments. label Dec 26, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 26, 2024

1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 26, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitde5f661
Direct Downloadwoocommerce-wear-prototype-build-pr13207-de5f661.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 26, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitde5f661
Direct Downloadwoocommerce-prototype-build-pr13207-de5f661.apk

@kidinov kidinov added the category: tracks Related to analytics, including Tracks Events. label Dec 26, 2024
@kidinov kidinov requested a review from a team as a code owner December 26, 2024 15:33
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.61%. Comparing base (9a2b63d) to head (de5f661).

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13207      +/-   ##
============================================
- Coverage     40.62%   40.61%   -0.02%     
+ Complexity     6372     6365       -7     
============================================
  Files          1345     1345              
  Lines         77271    77242      -29     
  Branches      10608    10604       -4     
============================================
- Hits          31395    31368      -27     
+ Misses        43115    43114       -1     
+ Partials       2761     2760       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. feature: mobile payments Related to mobile payments / card present payments / Woo Payments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove First TTP usage survey
4 participants