[Woo POS] Crash when plugin either attempted to be installed or activated by a show manager #13203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12957
Description
It's been crashing when in the POS during the onboarding flow a shop manager was trying to install or activate WooPayments/Stripe
The crash caused by
uiMessageResolver.showSnack(event.message)
inside ofCardReaderOnboardingFragment
, asUiMessageResolver
uses hardcodedsnack_root
id forCoordinatorLayout
, which was called differently inWooPosCardReaderActivity
Steps to reproduce
The tests that have been performed
Above
Images/gif
12-25--12-02.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: