Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Payments] IPP config for Puerto Rico #13200

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Dec 25, 2024

Closes: #13101

Description

The PR makes use of the US card reader for Puerto Rico. That makes it possible to collect IPP and TTP payments in PR. All this is based on the assumption that as PR is the US territory

The one obvious downside of this approach is that we use CardReaderConfigForSupportedCountry.countryCode in the building information for the "try TTP screen", including the link:
https://woocommerce.com/products/hardware/{countryCode}. https://woocommerce.com/products/hardware/pr doesnt not exist, though, while https://woocommerce.com/products/hardware/us offers at least to select PR as the delivery address (I don't know if we actually deliver there, though)

@malinajirka wdyt?

Testing information

I changed a store address to PR and test both IPP and TTP, but I am not sure if it's enouph

The tests that have been performed

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov added the feature: mobile payments Related to mobile payments / card present payments / Woo Payments. label Dec 25, 2024
@kidinov kidinov added this to the 21.4 milestone Dec 25, 2024
@kidinov kidinov requested a review from samiuelson December 25, 2024 09:56
@kidinov kidinov linked an issue Dec 25, 2024 that may be closed by this pull request
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 25, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit0545377
Direct Downloadwoocommerce-wear-prototype-build-pr13200-0545377.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 25, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit0545377
Direct Downloadwoocommerce-prototype-build-pr13200-0545377.apk

@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.62%. Comparing base (9a2b63d) to head (0545377).

Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #13200   +/-   ##
=========================================
  Coverage     40.62%   40.62%           
  Complexity     6372     6372           
=========================================
  Files          1345     1345           
  Lines         77271    77271           
  Branches      10608    10608           
=========================================
  Hits          31395    31395           
  Misses        43115    43115           
  Partials       2761     2761           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: mobile payments Related to mobile payments / card present payments / Woo Payments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IPP] Add IPP config for Puerto Rico
3 participants