-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Payments] IPP config for Puerto Rico #13200
Open
kidinov
wants to merge
4
commits into
trunk
Choose a base branch
from
13101-ipp-add-ipp-config-for-puerto-rico
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidinov
added
the
feature: mobile payments
Related to mobile payments / card present payments / Woo Payments.
label
Dec 25, 2024
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #13200 +/- ##
=========================================
Coverage 40.62% 40.62%
Complexity 6372 6372
=========================================
Files 1345 1345
Lines 77271 77271
Branches 10608 10608
=========================================
Hits 31395 31395
Misses 43115 43115
Partials 2761 2761 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13101
Description
The PR makes use of the US card reader for Puerto Rico. That makes it possible to collect IPP and TTP payments in PR. All this is based on the assumption that as PR is the US territory
The one obvious downside of this approach is that we use
CardReaderConfigForSupportedCountry.countryCode
in the building information for the "try TTP screen", including the link:https://woocommerce.com/products/hardware/{countryCode}
. https://woocommerce.com/products/hardware/pr doesnt not exist, though, while https://woocommerce.com/products/hardware/us offers at least to select PR as the delivery address (I don't know if we actually deliver there, though)@malinajirka wdyt?
Testing information
I changed a store address to PR and test both IPP and TTP, but I am not sure if it's enouph
The tests that have been performed
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: