[Dependency Cache] Dependency Cache on CI per Project [without GRADLE_RO_DEP_CACHE] #13170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMI ID: ami-06a633c14b35c40b9 AMI Name: android-build-image-6.12.0v1.4-rc-1
With this hook present, every build and its within jobs are all restoring the dependency cache, even when this is not really needed, and as such potentially delaying some jobs unnecessarily, while also consuming unnecessary resources (downloading from s3, (un)compressing, etc). FYI: It is better to use 'restore_gradle_dependency_cache' only on those jobs that could really benefit from it.
ParaskP7
added
status: do not merge
Generated by 🚫 Danger |
4 tasks
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
ParaskP7
force-pushed
the
ci/enable-dependency-cache-on-ci-v2
branch
7 times, most recently
from
3e154f3 to
36efb6d
Compare
FYI: This job will be then used by 'buildkite-ci' and configured as a 'buildkite_pipeline_schedule' with a weekly frequency.
Since the hook was removed (145a096), no build and its within jobs can restore the dependency cache, that is, unless if it is explicitly specified, just like it is done for mobile app prototype step via this change.
This change effectively reverts this initial 0dcd7b8 commit.
The targeted steps are: - Mobile App - Wear App - Lint - Detekt - Unit Tests - Android tests
ParaskP7
force-pushed
the
ci/enable-dependency-cache-on-ci-v2
branch
from
2debe7c to
13cbd88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #13122
Description
This is a test only PR that attempts to test another dependency cache mechanism, one that does NOT dependent on the read-only cache (GRADLE_RO_DEP_CACHE), and per project.
Testing information
N/ATip
To verify that
GRADLE_RO_DEP_CACHEis NOT enabled make sure you don't see thisShared read-only dependency cache is an incubating feature.log when Gradle launches for a CI build (example).RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: