Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.google.firebase:firebase-bom from 32.7.1 to 33.7.0 #13082

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 5, 2024

Bumps com.google.firebase:firebase-bom from 32.7.1 to 33.7.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps com.google.firebase:firebase-bom from 32.7.1 to 33.7.0.

---
updated-dependencies:
- dependency-name: com.google.firebase:firebase-bom
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the bot: dependencies update PRs that update a dependency file, used by Dependabot. label Dec 5, 2024
@dependabot dependabot bot requested review from a team and wzieba and removed request for a team December 5, 2024 18:43
@dependabot dependabot bot requested a review from malinajirka December 5, 2024 18:43
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 5, 2024

Project dependencies changes

Content exceeds 65400 characters. Navigate to Buildkite build artifacts to see details.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 5, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit2f09378
Direct Downloadwoocommerce-wear-prototype-build-pr13082-2f09378.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 5, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit2f09378
Direct Downloadwoocommerce-prototype-build-pr13082-2f09378.apk

@wzieba wzieba removed their request for review December 10, 2024 10:31
@malinajirka malinajirka added this to the 21.3 milestone Dec 13, 2024
@malinajirka
Copy link
Contributor

malinajirka commented Dec 13, 2024

I've started reviewing this PR, but considering the number of changes in dependencies, I believe we first need to wait for #13103 to be merged. Below are the notes from my initial review.

I plan to test:

  • Push notifications
  • Remote Config
  • Barcode scanning

I removed imports containing ktx as it has been deprecated as per this article.

This PR updates the following libraries:

✅ com.google.firebase:firebase-config | 21.6.0 | 22.0.1
✅ com.google.firebase:firebase-analytics | 21.5.0 | 22.1.2

✅ com.google.firebase:firebase-messaging | 23.4.0 | 24.1.0
✅ com.google.firebase:firebase-installations | 17.2.0 | 18.0.0
✅ com.google.firebase:firebase-components:18.0.0, (changed from 17.1.5)
✅ com.google.firebase:firebase-config-interop:16.0.1, (changed from 16.0.0)
✅ com.google.firebase:firebase-datatransport:18.2.0, (changed from 18.1.7)

com.google.firebase:firebase-common | 20.4.2 | 21.0.0
com.google.firebase:firebase-common-ktx | 20.4.2 | 21.0.0

These two don't have any change log. I'm not sure if that's because they are shared utilities or because I'm missing something else.

com.google.android.datatransport:transport-backend-cct:3.1.9, (changed from 3.1.8)
com.google.android.datatransport:transport-runtime:3.1.9, (changed from 3.1.8)

We'll need to smoke test barcode scanning to ensure this small update doesn't cause a regression.

com.google.android.gms:play-services-base:18.5.0, (changed from 18.1.0)
com.google.android.gms:play-services-tasks:18.2.0, (changed from 18.0.2)
com.google.android.gms:play-services-basement:18.4.0, (changed from 18.2.0)

These three will be updated as part of #13103.

com.google.android.gms:play-services-cloud-messaging:17.2.0, (changed from 17.1.0)
com.google.android.gms:play-services-measurement:22.1.2, (changed from 21.5.0)
com.google.android.gms:play-services-measurement-api:22.1.2, (changed from 21.5.0)
com.google.android.gms:play-services-measurement-base:22.1.2, (changed from 21.5.0)
com.google.android.gms:play-services-measurement-impl:22.1.2, (changed from 21.5.0)
com.google.android.gms:play-services-measurement-sdk:22.1.2, (changed from 21.5.0)
com.google.android.gms:play-services-measurement-sdk-api:22.1.2, (changed from 21.5.0)

These all are transitive dependencies, so they are unlikely to break something in our own code.

@wpmobilebot
Copy link
Collaborator

Version 21.3 has now entered code-freeze, so the milestone of this PR has been updated to 21.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: dependencies update PRs that update a dependency file, used by Dependabot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants