Prevent duplicate conversion and purchase event tracking #2734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Because of a strict comparison check for the
_gla_tracked
meta we were allowing the conversion and purchase snippets to show again if the order thank you page is refreshed (not loaded from cache).This PR converts the meta value to an integer before doing the strict comparison. I've also added some unit tests to confirm that the tracking snippet isn't output in conditions where it should not. The WP proxy class had to be used to facilitate mocking of some WP functions.
Closes #2733
Detailed test instructions:
gtag("event", "conversion"
gtag("event", "purchase"
Changelog entry