Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump symfony/validator from 5.4.30 to 5.4.43 #2663

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 6, 2024

Bumps symfony/validator from 5.4.30 to 5.4.43.

Release notes

Sourced from symfony/validator's releases.

v5.4.43

Changelog (symfony/validator@v5.4.42...v5.4.43)

v5.4.42

Changelog (symfony/validator@v5.4.41...v5.4.42)

v5.4.41

Changelog (symfony/validator@v5.4.40...v5.4.41)

v5.4.40

Changelog (symfony/validator@v5.4.39...v5.4.40)

v5.4.39

Changelog (symfony/validator@v5.4.38...v5.4.39)

v5.4.38

Changelog (symfony/validator@v5.4.37...v5.4.38)

v5.4.36

Changelog (symfony/validator@v5.4.35...v5.4.36)

v5.4.35

Changelog (symfony/validator@v5.4.34...v5.4.35)

v5.4.34

Changelog (symfony/validator@v5.4.33...v5.4.34)

... (truncated)

Commits
  • 21d022d synchronize IBAN formats
  • a1b845a [Translation] Review Serbian translations
  • a28c302 [Validator] added Polish translation for units 116-119
  • 6586306 minor #57987 [Validator] add German translations for the Week constraint mess...
  • 30a719d add German translations for the Week constraint messages
  • 3a2f903 bug #57984 [Validator] Add D regex modifier in relevant validators (alexand...
  • f44d137 sync Week constraint messages translations
  • eac749c [Validator] Add D regex modifier in relevant validators
  • f34398f [Validator] Add French translation for the Week constraint
  • e6ef5f2 reset the validation context after validating nested constraints
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added php Pull requests that update Php code type: technical debt - dependency extraction This issue/PR suffers from the dependency extraction and management labels Nov 6, 2024
@eason9487 eason9487 removed the type: technical debt - dependency extraction This issue/PR suffers from the dependency extraction and management label Nov 7, 2024
@eason9487
Copy link
Member

@dependabot rebase

Bumps [symfony/validator](https://github.com/symfony/validator) from 5.4.30 to 5.4.43.
- [Release notes](https://github.com/symfony/validator/releases)
- [Changelog](https://github.com/symfony/validator/blob/7.1/CHANGELOG.md)
- [Commits](symfony/validator@v5.4.30...v5.4.43)

---
updated-dependencies:
- dependency-name: symfony/validator
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/composer/symfony/validator-5.4.43 branch from e0fc0e7 to 8d30497 Compare November 25, 2024 09:47
@eason9487
Copy link
Member

The following test failed because symfony/validator 5.4.43 adjusts the validation of URL paths to allow Unicode mark and symbol characters. There is a more detailed research in #2647 (comment)

public function test_invalid_image_names() {
$product = WC_Helper_Product::create_simple_product();
$main_image = $this->generate_mock_image_attachment( $product->get_id(), '600-×-300.png' );
$additional_images = [ $this->generate_mock_image_attachment( $product->get_id(), 'æą€.jpg' ) ];
$product->set_image_id( $main_image );
$product->set_gallery_image_ids( $additional_images );
$product->save();
$adapted_product = new WCProductAdapter(
[
'wc_product' => $product,
'targetCountry' => 'US',
]
);
$violation = $this->validate_product_property( $adapted_product, 'imageLink' );
$this->assertEquals(
'Product image "600-×-300.png" is not a valid name.',
$this->validate_product_property( $adapted_product, 'imageLink' )->getMessage()
);
$this->assertEquals(
'Product image "æą€.jpg" is not a valid name.',
$this->validate_product_property( $adapted_product, 'additionalImageLinks' )->getMessage()
);
}

@mikkamp
Copy link
Contributor

mikkamp commented Dec 9, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 9, 2024

Looks like symfony/validator is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Dec 9, 2024
@dependabot dependabot bot deleted the dependabot/composer/symfony/validator-5.4.43 branch December 9, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants