Prevent PHP Warning when Statistics is null #2400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes part of #2398
This PR prevents a PHP warning when
statistics
is null as we try to access ['statistics']['active`] in some parts of the code without checking if it's set.Detailed test instructions:
wc_gla_cron_daily_notes
)Notice that some conditions are required for this Note to be triggered. For testing this I recommend commenting off some checks under
AbstractSetupCampaign::should_be_added
or be sure you pass all those checks.So we can focus on the problematic method
$this->merchant_center_service->has_at_least_one_synced_product()
Additional details:
Changelog entry