-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an empty Reports Products page, move Reports Programs files around #170
Conversation
The changes look pretty simple, looks good to me. Probably needs some PHP expert's eyes on the PHP code 😄
I think the page title should be "Programs Report", as in "a report about programs" 🤔 . |
Yeah I think I'd agree - either "Programs Report" or just "Programs" and similarly "Products Report" or just "Products". I look at as we have 2 reports - a "Programs report" and a "Products report". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing well for me, I think it just a couple of the title tweaked for consistency - similar to what @ecgan mentions
js/src/index.js
Outdated
title: __( 'Reports', 'google-listings-and-ads' ), | ||
container: Reports, | ||
path: '/google/reports', | ||
title: __( 'Programs Reports', 'google-listings-and-ads' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Programs Report for consistency below
js/src/index.js
Outdated
], | ||
__( 'Google Listings & Ads', 'google-listings-and-ads' ), | ||
], | ||
title: __( 'Products Reports', 'google-listings-and-ads' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Products Report for consistency below
as suggested at #170 (comment).
This is a baby step for #97 and #98, that would help to develop those two independently.
It also divides the work, that most of renaming and moving around is separated here, and should not blur the picture on other PRs.
Changes proposed in this Pull Request:
/reports
folders and namespace. (0254251)/reports/products
page. (96c9b11)Screenshots:
Detailed test instructions:
npm install && composer install && npm run build
localhost/wordpress
with your local env)Changelog Note:
none
Additional comments
I have stopped before implementing the sub-navigation as required in #98, to:
Given, I'm not native English, I wasn't sure whether the page title should be "Reports Programs", "Programs Reports" or "Program Reports". I left it as it was in Figma's node title.