66 add custom 404 page #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luciagirasoles
approved these changes
Jan 18, 2024
|
Hi @MooseCowBear can you contact me on the WNB.rb Slack? I have an info to share with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #66
This pull creates a custom not found page consistent with the theme of the site.
I modified the existing application#render_not_found method and added a views/application directory to hold the view. I'm not sure if that is how you would like it. Maybe it would be better in the views/site directory? Let me know and I can change it.
I also added a test. Again, not sure where the best place for it is.