Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination for admin views #207

Merged
merged 3 commits into from
Dec 23, 2023

Conversation

KattyaCuevas
Copy link
Contributor

Issue: #64

Description
Add pagy gem for pagination and use the pagination helper in the events#index view

Requirements from the issue

  • The GET admin/events endpoint accepts a page parameter
  • The endpoint uses this parameter to determine which events to display on the page (i.e., if page is 1, display the first 25 events; if page is 2, display events 26-50, etc.)
  • UI is added to the view, allowing the user to navigate between pages if more than one results page exists.
  • If only one page of results exists, the UI does not allow the user to navigate between pages

UI:
Screenshot 2023-12-12 at 17 33 30

@KattyaCuevas
Copy link
Contributor Author

@luciagirasoles this PR is ready for review 💯

@KattyaCuevas KattyaCuevas force-pushed the add-pagination branch 2 times, most recently from 2bd6c44 to 6d5e9d1 Compare December 13, 2023 17:23
Copy link
Collaborator

@luciagirasoles luciagirasoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Kattya

@luciagirasoles luciagirasoles merged commit 2798a3b into wnbrb:main Dec 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants