Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkg-config to find system leveldb #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

njwhite
Copy link

@njwhite njwhite commented Aug 26, 2014

Don't embed our own copy of LevelDB - build against the system on (the one pkg-config knows about) instead.

@vjoel
Copy link

vjoel commented Aug 26, 2014

I've been down this road already :)

https://github.com/vjoel/ruby-leveldb-native

Would you like to join that repo?

Btw, @wmorgan no longer maintains this repo and gave his blessing to ruby-leveldb-native.

@vjoel
Copy link

vjoel commented Aug 26, 2014

Another approach, instead of pkg-config (not sure how widely installed that is outside of linux), would be to use rake-compiler, as in https://github.com/minad/lmdb. This repo is sort of the best of both worlds: it has a bundled version of lmdb, but tries to find installed libs first. (And you can override that too.)

@vjoel
Copy link

vjoel commented Aug 26, 2014

I've been meaning to use rake-compiler in https://github.com/vjoel/ruby-leveldb-native, but I'm just more interested in working on lmdb now.

@njwhite
Copy link
Author

njwhite commented Aug 27, 2014

@vjoel I will, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants