Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inject api-endpoint during buildtime #399

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

aeweda
Copy link
Collaborator

@aeweda aeweda commented Apr 25, 2024

No description provided.

@aeweda aeweda self-assigned this Apr 25, 2024
@aeweda aeweda requested a review from Tommytrg April 25, 2024 10:55
@Tommytrg
Copy link
Member

With this approach, we build the image every time we deploy to staging and production environments. What's the downtime when we create a new image before deploying it to production?

@aeweda
Copy link
Collaborator Author

aeweda commented Apr 30, 2024

With this approach, we build the image every time we deploy to staging and production environments. What's the downtime when we create a new image before deploying it to production?

docker doesn't rebuild layers that already exist, so it's just the build time of the app itself, for production, i doubt more than 10 minutes for the whole thing

@aeweda aeweda merged commit 9b489f8 into main Apr 30, 2024
1 check passed
@Tommytrg Tommytrg deleted the identify-api-endpoint-during-buildtime branch July 16, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants