Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPB-14284 personal user invitation URL configmap fixed #4341

Merged
merged 3 commits into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/0-release-notes/WPB-14284
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
If brig's server values config has the field `emailSMS.team`, the correct value for the personal user to team invitation URL must be set under `emailSMS.team.tExistingUserInvitationUrl`. Otherwise the URL will point to a path under the account pages and therefore a value for `externalUrls.accountPages` is required.
1 change: 1 addition & 0 deletions changelog.d/3-bug-fixes/WPB-14284
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed config for personal user to team invitation URL template.
3 changes: 1 addition & 2 deletions charts/brig/templates/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -186,14 +186,13 @@ data:
{{- else }}
{{- if .externalUrls.teamSettings }}
tInvitationUrl: {{ .externalUrls.teamSettings }}/join/?team-code=${code}
tExistingUserInvitationUrl: {{ .externalUrls.teamSettings }}/accept-invitation/?team-code=${code}
{{- else }}
tInvitationUrl: {{ .externalUrls.nginz }}/register?team=${team}&team_code=${code}
tExistingUserInvitationUrl: {{ .externalUrls.nginz }}/accept-invitation/?team-code=${code}
{{- end }}
tActivationUrl: {{ .externalUrls.nginz }}/register?team=${team}&team_code=${code}
tCreatorWelcomeUrl: {{ .externalUrls.teamCreatorWelcome }}
tMemberWelcomeUrl: {{ .externalUrls.teamMemberWelcome }}
tExistingUserInvitationUrl: {{ .externalUrls.accountPages }}/accept-invitation/?team-code=${code}
{{- end }}

zauth:
Expand Down
21 changes: 21 additions & 0 deletions docs/src/developer/reference/config-options.md
Original file line number Diff line number Diff line change
Expand Up @@ -801,6 +801,27 @@ This setting is required to be present for all the services (brig, cannon, cargo

The default value (provided under `charts/<service>/values.yaml`) is `[ development ]` and disables the development versions. To enable all versions including the development versions set the value to be empty: `[]`.

### Team invitation URL for personal users

To configure the team invitation URL for personal users that is sent vai email, `emailSMS.team.tExistingUserInvitationUrl` should be set to the desired URL, e.g.:

```yaml
brig:
config
emailSMS:
team:
tExistingUserInvitationUrl: '{{ .Values.accountUrl }}/accept-invitation/?team-code=${code}'
```

In some environments the `team` config section does not exist. In this case brig's configmap constructs the URL from the account pages URL which then must be set under `externalUrls.accountPages` e.g. as follows:

```yaml
brig:
config:
externalUrls:
accountPages: https://account.wire.com
```

## Settings in cargohold

AWS S3 (or an alternative provider / service) is used to upload and download
Expand Down
5 changes: 3 additions & 2 deletions hack/helm_vars/wire-server/values.yaml.gotmpl
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ brig:
nginz: https://kube-staging-nginz-https.zinfra.io
teamCreatorWelcome: https://teams.wire.com/login
teamMemberWelcome: https://wire.com/download
accountPages: https://account.wire.com
cassandra:
host: {{ .Values.cassandraHost }}
replicaCount: 1
Expand Down Expand Up @@ -134,7 +135,7 @@ brig:
setOAuthEnabled: true
setOAuthRefreshTokenExpirationTimeSecs: 14515200 # 24 weeks
setOAuthMaxActiveRefreshTokens: 10
# These values are insecure, against anyone getting hold of the hash,
# These values are insecure, against anyone getting hold of the hash,
# but its not a concern for the integration tests.
setPasswordHashingOptions:
algorithm: argon2id
Expand Down Expand Up @@ -281,7 +282,7 @@ galley:
federationDomain: integration.example.com
disabledAPIVersions: []

# These values are insecure, against anyone getting hold of the hash,
# These values are insecure, against anyone getting hold of the hash,
# but its not a concern for the integration tests.
passwordHashingOptions:
algorithm: argon2id
Expand Down
Loading