feat: Remove option to select protocol in create group - WPB-10442 #2148
Conversation
echoes-hq
bot
added
the
echoes: unplanned
| @@ -113,7 +113,6 @@ final class ConversationCreationController: UIViewController { | |||
|
|
|||
| private lazy var encryptionProtocolSection = { | |||
| let section = ConversationEncryptionProtocolSectionController(values: values) | |||
| section.isHidden = true | |||
There was a problem hiding this comment.
This was not fixed during the conversation creation view refactoring.
Test Results 3 files 339 suites 3m 6s ⏱️ Results for commit aeea6e7. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
I don't see removing MLS_ENABLED following the PR in wire-ios-build-assets + updating the submodule ref.
@KaterinaWire do you plan another PR for this?
@netbe I'm removing MLS_ENABLED in #2129 I will update the submodule ref when PR for |
| @@ -87,7 +87,7 @@ public enum DeveloperFlag: String, CaseIterable { | |||
| case .enableMLSSupport: | |||
| return "MLSEnabled" | |||
| case .showCreateMLSGroupToggle: | |||
| return "CreateMLSGroupEnabled" | |||
| return nil | |||
There was a problem hiding this comment.
OK so returning nil here means it is still available for developer builds but not for regular builds?
Issue
By default, we should not see the selection of protocols when creating a conversation. However, this should be possible for testing.
Testing
By default, the option to select a protocol when creating a group should be hidden.
Needs to release with
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: