fix: transparent background on connect for iPad - WPB-12041 #2140
+41
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: product-roadmap
netbe
requested review from
a team,
agisilaos,
johnxnguyen and
jullianm
and removed request for
a team
caldrian
approved these changes
Nov 11, 2024
samwyndham
reviewed
Nov 11, 2024
| @@ -38,7 +38,21 @@ extension StartUIViewController { | |||
| extension StartUIViewController: ShareContactsViewControllerDelegate { | |||
|
|
|||
| func shareContactsViewControllerDidFinish(_ viewController: ShareContactsViewController) { | |||
| viewController.dismiss(animated: true) | |||
| guard !needsAddressBookPermission else { | |||
| // do nothing just dismiss | |||
There was a problem hiding this comment.
Just to check I assume this is being dismissed by something else in this case
There was a problem hiding this comment.
this guard else never happens, removed
|
|
||
| // On iPad, add an estimated accessory height if applicable | ||
| if traitCollection.userInterfaceIdiom == .pad { | ||
| keyboardHeight += 44 // Approximate height of an input accessory view |
There was a problem hiding this comment.
I'm pretty sure there must be a way to do this without resorting to an estimate which may break. Have you looked into this much?
There was a problem hiding this comment.
good point, but I haven't found any way to get it so far
Test Results1 794 tests 1 788 ✅ 2m 37s ⏱️ For more details on these failures, see this check. Results for commit 8816f3f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
presentOverAll()to avoid access to deprecated shared instanceTesting
login on iPad with personal account
tap connect
tap invite
check also flows on iPhone