Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SourceLink #2361

Merged
merged 2 commits into from
Jan 3, 2025
Merged

fix SourceLink #2361

merged 2 commits into from
Jan 3, 2025

Conversation

ge0rdi
Copy link
Contributor

@ge0rdi ge0rdi commented Jan 3, 2025

This fixes regression introduced in f1516d6 .

Current sourcelink stream looks like this:

{
  "documents": {
    "\\*": "https://raw.githubusercontent.com/winsiderss/systeminformer/609ffb2547bd54741d49a4ed50efe7e6fe2922ed*",
    "D:\\a\\1\\s\\*": "https://raw.githubusercontent.com/winsiderss/systeminformer/609ffb2547bd54741d49a4ed50efe7e6fe2922ed*"
  }
}

Note that / is missing before * wildcard in URL part. That's obvious mistake.

Then there seems to be problem with source path matching.
In PDBs they look like SystemInformer\main.c, phlib\native.c (due to deterministic builds).
So they don't match \\* pattern.
With * as path pattern everything works nicely.

@jxy-s jxy-s merged commit 10805c6 into winsiderss:master Jan 3, 2025
3 checks passed
@ge0rdi ge0rdi deleted the fix-sourcelink branch January 3, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants