Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phnt bcdapi fixes #2342

Merged
merged 1 commit into from
Dec 23, 2024
Merged

phnt bcdapi fixes #2342

merged 1 commit into from
Dec 23, 2024

Conversation

RatinCN
Copy link
Contributor

@RatinCN RatinCN commented Dec 23, 2024

I inspected those APIs and seems some parameters should be PCUNICODE_STRING.

@RatinCN RatinCN requested review from dmex and jxy-s as code owners December 23, 2024 05:49
@dmex dmex merged commit 0e66049 into winsiderss:master Dec 23, 2024
1 check passed
@RatinCN
Copy link
Contributor Author

RatinCN commented Dec 23, 2024

Note: this change is not only change it to const, but also it seems should be a pointer.

@dmex
Copy link
Member

dmex commented Dec 23, 2024

@RatinCN Microsoft publishes the BCD functions in IL metadata:

C:\Windows\System32\WindowsPowerShell\v1.0\Modules\Microsoft.Windows.Bcd.Cmdlets\Microsoft.Windows.Bcd.dll

image

@RatinCN
Copy link
Contributor Author

RatinCN commented Dec 23, 2024

@RatinCN Microsoft publishes the BCD functions in IL metadata:

C:\Windows\System32\WindowsPowerShell\v1.0\Modules\Microsoft.Windows.Bcd.Cmdlets\Microsoft.Windows.Bcd.dll

image

Thanks for your information!

@RatinCN RatinCN deleted the phnt_bcd_fix branch January 2, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmex dmex dmex approved these changes

@jxy-s jxy-s Awaiting requested review from jxy-s jxy-s is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RatinCN @dmex