Skip to content

Commit

Permalink
objmgr remove wrong context deletion
Browse files Browse the repository at this point in the history
Context was created using PhCreateAlloc (ref-counted object) so it is
wrong to call PhFree on it.

It will be automatically freed when property sheet is destroyed.
  • Loading branch information
ge0rdi committed Jan 3, 2025
1 parent b44c63a commit 6aa0dde
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions plugins/ExtendedTools/objprp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1821,7 +1821,6 @@ INT_PTR CALLBACK EtpObjHandlesPageDlgProc(
{
PhDeleteLayoutManager(&context->LayoutManager);
PhRemoveWindowContext(hwndDlg, PH_WINDOW_CONTEXT_DEFAULT);
PhFree(context);
}
break;
case WM_KEYDOWN:
Expand Down Expand Up @@ -2396,7 +2395,6 @@ INT_PTR CALLBACK EtpWinStaPageDlgProc(
{
PhDeleteLayoutManager(&context->LayoutManager);
PhRemoveWindowContext(hwndDlg, PH_WINDOW_CONTEXT_DEFAULT);
PhFree(context);
}
break;
case WM_NOTIFY:
Expand Down

0 comments on commit 6aa0dde

Please sign in to comment.