fix: add support for EL10 #293
Conversation
According to the Ansible team, support for listing platforms in role `meta/main.yml` files is being removed. Instead, they recommend using `galaxy_tags` https://github.com/ansible/ansible/blob/stable-2.17/changelogs/CHANGELOG-v2.17.rst "Remove the galaxy_info field platforms from the role templates" ansible/ansible#82453 For each version listed under `platforms.EL` - add a tag like `elN`. Q: Why not use a delimiter between the platform and the version e.g. `el-10`? This is not allowed by ansible-lint: ``` meta-no-tags: Tags must contain lowercase letters and digits only., invalid: 'el-10' meta/main.yml:1 ``` So we cannot use uppercase letters either. Q: Why not use our own meta/main.yml field? No other fields are allowed by ansible-lint: ``` syntax-check[specific]: 'myfield' is not a valid attribute for a RoleMetadata ``` Q: Why not use some other field? There are no other applicable or suitable fields. Q: What happens when we want to support versions like `N.M`? Use the word "dot" instead of "." e.g. `el10dot3`. Similarly - use "dash" instead of "-". We do not need tags such as `fedoraall`. The `fedora` tag implies that the role works on all supported versions of fedora. Otherwise, use tags such as `fedora40` if the role only supports specific versions. In addition - for roles that have different variable files for EL9, create the corresponding EL10 files, and update the variables for EL10. Signed-off-by: Rich Megginson <[email protected]>
|
Note - I wanted to add an ansible check github action for centos10 - there isn't one - the centos-latest check still points to quay.io centos:latest which is centos 8 (!) |
|
Please, update also readme with the el10.
I would find useful to have something that follows
Well ... thats the latest centos released ... others are streams: https://quay.io/repository/centos/centos?tab=tags&tag=latest Regarding the failing CentOS7, its EOL so the mirrors were moved. If we would like to run tests against it, we will have to fix the mirrors similar way as for CentOS6 and CentOS8. Can you check if this works? |
Done.
Right - ok.
Passed! |
I can revert 9a7c358 from the PR, then we can merge. |
According to the Ansible team, support for listing platforms in
role
meta/main.ymlfiles is being removed.Instead, they recommend using
galaxy_tagshttps://github.com/ansible/ansible/blob/stable-2.17/changelogs/CHANGELOG-v2.17.rst
"Remove the galaxy_info field platforms from the role templates"
ansible/ansible#82453
For each version listed under
platforms.EL- add a tag likeelN.Q: Why not use a delimiter between the platform and the version e.g.
el-10?This is not allowed by ansible-lint:
So we cannot use uppercase letters either.
Q: Why not use our own meta/main.yml field?
No other fields are allowed by ansible-lint:
Q: Why not use some other field?
There are no other applicable or suitable fields.
Q: What happens when we want to support versions like
N.M?Use the word "dot" instead of "." e.g.
el10dot3.Similarly - use "dash" instead of "-".
We do not need tags such as
fedoraall.The
fedoratag implies that the role works on all supported versions of fedora.Otherwise, use tags such as
fedora40if the role only supports specific versions.In addition - for roles that have different variable files for EL9, create
the corresponding EL10 files, and update the variables for EL10.
Signed-off-by: Rich Megginson [email protected]