Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI failure #288

Closed
wants to merge 4 commits into from
Closed

fix: CI failure #288

wants to merge 4 commits into from

Conversation

mattwillsher
Copy link
Member

Enhancement:

Reason:

Result:

Issue Tracker Tickets (Jira or BZ if any):

@Jakuje
Copy link
Collaborator

Jakuje commented May 31, 2024

The Ubuntu is now broken (roles-ansible/check-ansible-ubuntu-latest-action#4) but fedora test should be fixed with:

diff --git a/tests/tests_all_options.yml b/tests/tests_all_options.yml
index d085c09..f2be4e6 100644
--- a/tests/tests_all_options.yml
+++ b/tests/tests_all_options.yml
@@ -93,7 +93,7 @@
           | grep -o '^\(     \|       \)[A-Z][A-Za-z0-9]*\(.\|  \)' \
           | grep -v "[A-Za-z0-9] $" | grep -v "[^A-Za-z0-9 ]$" \
           | awk '{ print $1 }' \
-          | grep -v '^$' | grep -v "^\(Match\|OpenSSH\|The\|Arguments\|Theo\)$"
+          | grep -v '^$' | grep -v "^\(Match\|OpenSSH\|The\|Arguments\|Theo\|Tatu\)$"
       args:
         executable: /bin/bash
       register: sshd_options

@mattwillsher mattwillsher changed the title Fix CI failure fix: CI failure Jun 1, 2024
@mattwillsher
Copy link
Member Author

The Ubuntu is now broken (roles-ansible/check-ansible-ubuntu-latest-action#4) but fedora test should be fixed with:
...

Fedora fix incorporated, thanks @Jakuje

I've raised a PR roles-ansible/check-ansible-ubuntu-latest-action#5 for the Ubuntu issue.

@Jakuje
Copy link
Collaborator

Jakuje commented Jun 1, 2024

I've raised a PR roles-ansible/check-ansible-ubuntu-latest-action#5 for the Ubuntu issue.

Thanks! You can test it works by changing the path to the action in the workflow file to your fork by replacing roles-ansible with mattwillsher here:

uses: roles-ansible/check-ansible-ubuntu-latest-action@master

but I do not expect any issues.

Use fork of Ansible Ubuntu latest action
@Jakuje
Copy link
Collaborator

Jakuje commented Jun 1, 2024

I was too fast. We obviously do not have Ubuntu 24 definition in https://github.com/willshersystems/ansible-sshd/tree/main/vars -- I assume just copy of the 22 version should give us some results.

@mattwillsher
Copy link
Member Author

Closing in favour of #289

@mattwillsher mattwillsher deleted the cifixes branch June 2, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants