This repository has been archived by the owner on Jul 21, 2021. It is now read-only.
safeExtGet and ignore .git folder #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@williambout This module is unusable without this pull request. Please consider merging it. |
geraintwhite
suggested changes
Dec 18, 2019
| @@ -31,6 +35,6 @@ repositories { | |||
| } | |||
|
|
|||
| dependencies { | |||
| compile 'com.facebook.react:react-native:+' | |||
| compile 'com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}' | |||
There was a problem hiding this comment.
There's a syntax error here resulting in a build failure:
* What went wrong:
A problem occurred evaluating project ':react-native-proximity'.
> Could not find method reactNativeVersion() for arguments [, )}] on DefaultExternalModuleDependency{group='com.facebook.react', name='react-native', version='${safeExtGet(', configuration='default'} of type org.gradle.api.internal.artifacts.dependencies.DefaultExternalModuleDependency.
Suggested change
| compile 'com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}' | |
| compile "com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
safeExtGetis a good practise from many popular packages, it will solve notification that this lib uses les sdk version.and second fix is kinda important, because without it, when trying to install next package, npm will send error
react-native-proximity: Appears to be a git repo or submodule.