Test for absence/presence of guide differently

[teunbrand]

Hi Claus,

It is me again, running down reverse dependency checks. I'm posting this because the prospective ggplot2 3.5.0 would break a test in ggridges.

The change is that a plot now always has guide boxes (though they are zero grobs if empty). Hence, testing for presence/absence of a guide by checking the gtable for the 'guide-box' name no longer works. This PR uses the new get_guide_data() to test for a legend's presence or absence.

For completion; to test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. I hope that this PR might help ggridges get out a fix if necessary.

[clauswilke]

Thanks, this looks rather straightforward. Could you just add a little comment, something like "Legend structure changed with ggplot2 3.5" or similar, so the conditional testing is properly documented for the future? Ideally on both tests.

[teunbrand]

You got it 👍

[clauswilke]

This is now on CRAN.

[teunbrand]

Thank you Claus!