Skip to content

Commit

Permalink
fix URL
Browse files Browse the repository at this point in the history
  • Loading branch information
clauswilke committed Sep 13, 2017
1 parent 840ea5c commit 9a82996
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
11 changes: 6 additions & 5 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
This is a minor version increase for ggridges, providing numerous improvements and new features. It also adds
a missing import statement that wasn't flagged by CRAN check for the previous submission.
This packages is meant as a replacement for the package 'ggjoy' currently on CRAN. I have changed the name because the term "joyplot" has an unfortunate history. It comes from the band Joy Division, which was named after Nazi concentration camp brothels (see here: https://en.wikipedia.org/wiki/House_of_Dolls ). In the 'ggridges' package, all references to "joyplots" have been changed into "ridgeline plots", and functions such as 'geom_joy' have been renamed into appropriate terms (e.g., 'geom_density_ridges').

Once 'ggridges' is on CRAN, I will replace the 'ggjoy' package with a placeholder package that simply exports the 'ggridges' functions under the old 'ggjoy' name and warns users that 'ggjoy' is deprecated.

One data file contains UTF-8 marked strings. The file contains election results from Catalania,
and the municipality names contain non-ASCII characters. None of these names make it into the
example figure that is generated from this file, so I think it is best to leave the file as is
example figure that is generated from this file, so it is best to leave the file as is
for completeness.

## Test environments
Expand All @@ -13,9 +14,9 @@ for completeness.
## R CMD check results
There were no ERRORs or WARNINGs.

There is one NOTE, about spelling:
There was one Note:
Possibly mis-spelled words in DESCRIPTION:
ridgeline plots (3:8, 8:14)
Ridgeline (3:8, 8:14)

The spelling is correct.

Expand Down
2 changes: 1 addition & 1 deletion vignettes/gallery.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Catalan_elections %>%

## Temperatures in Lincoln, Nebraska

Modified from a [blog post](http://austinwehrwein.com/data-visualization/it-brings-me-ggridges/) by Austin Wehrwein.
Modified from a [blog post](http://austinwehrwein.com/data-visualization/it-brings-me-ggjoy/) by Austin Wehrwein.
```{r message=FALSE, fig.width = 7.5, fig.height = 5}
library(viridis)
ggplot(lincoln_weather, aes(x = `Mean Temperature [F]`, y = `Month`, fill = ..x..)) +
Expand Down

0 comments on commit 9a82996

Please sign in to comment.