Skip to content

Commit

Permalink
cowplot 0.6
Browse files Browse the repository at this point in the history
  • Loading branch information
clauswilke committed Dec 19, 2015
1 parent 766f373 commit 729e135
Showing 1 changed file with 3 additions and 28 deletions.
31 changes: 3 additions & 28 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,36 +1,11 @@

** Please read these explanations in full before rejecting my submission. Thanks! **

## Test environments
* R-devel on win-builder [ via devtools::build_win(version = "R-devel") ]
* R 3.2.3 on win-builder [ via devtools::build_win() ]
(R devel on win-builder doesn't have ggplot 2.0 yet, so I couldn't check that.)
* local OS X install x86_64-apple-darwin13.4.0 (64-bit), R 3.2.2

## R CMD check results
There were no ERRORs or WARNINGs.

There are two NOTEs, one under `checking R code for possible problems` and one under `checking dependencies in R code`. Both have the same cause, namely that I have added conditional code for the latest development version of ggplot2, which is slated to be released within the next few days. This was done by request of Hadley Wickham, so that packages that depend on ggplot2 will work immediatedly once he releases his next version.

The code I have added is of the form:
if (utils::packageVersion("ggplot2")<="1.0.1"){
# code for current stable version
}
else{
# code for development version
}
The code for the development version is using two attributes of `element_text` that don't exist in the current stable version: `margin` and `debug`. As a consequence, R CMD check generates notes of the form:
theme_cowplot: possible error in element_text(family = font_family,
face = "plain", colour = "black", size = font_size, hjust = 0.5,
vjust = 0.5, angle = 0, lineheight = 0.9, margin = ggplot2::margin(),
debug = FALSE): unused arguments (margin = ggplot2::margin(), debug =
FALSE)

Similarly, the code for the development version is using a function `ggplot2::margin` which doesn't exist in the current stable version of ggplot2, and that causes this NOTE:
* checking dependencies in R code ... NOTE
Missing or unexported object: 'ggplot2::margin'

The only way to fix these NOTEs is to remove support for the development version of ggplot2, which would defeat the purpose of this CRAN submission.

I have carefully tested this code many times with both the current stable version and the development version of ggplot2, and all examples and tests work fine for both versions.
There were no ERRORs, WARNINGs, or NOTEs.

## Downstream dependencies
None exist at this time.

0 comments on commit 729e135

Please sign in to comment.