WIP Restructured/refactored project. #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed the following variables used in the cookiecutter context:
project_title --> project_name
project_name --> project_slug
Before the names were too similar. Using project_slug makes the purpose
much clearer and will reduce the chance of making errors in future changes
to the code.
Remove the variable, model_name_lower from the cookiecutter JSON file: 1. It's one less variable for the person running the cookiecutter script to deal with. 2. The variable is easily handled by using the lower filter on model_name. 3. It's one less thing to go wrong.
Added configuration variables for the following: 1. domain and subdomain so the project can deal with configuration of servers. 2. Django secrey key. Generating the key is a nuisance so this is going to be automated. 3. Python version so the virtualenv for running the project can be generated as part of the installation process.
1. Updated the test scripts to deal with the added configuration variables. 2. Added a configuration file for tox so we can run tests for python 3.4, 3.5 and 3.6.
Updated the deployment to use fabric and invoke. Created a set of invoke tasks that are organised by the service or feature it installs/manages. That will make it much easier to add new features. Templates are rendered in two steps. First the cookiecurrent values are filled in. Then during the deployment the values from fabric.json are used to fill out template variables (escaped in the first step). That makes it much easier to deploy projects with different layouts. Added features from various sources.
Remove the task to restart celery and celery beat. When supervisor loads the configuration using the restart command all the processes added (celery, celery beat and uwsgi) will be (re)started. Removed the reread command when restarting supervisor. The update command rereads all the configurations and adds/removes the processes as necessary.
Tasks that install operating system packages called apt_update to refresh the package database so the latest versions could be installed. That meant that during a full deploy apt-get update was being called several times unecessarily. The deploy.full() task was updated so apt-get update is only peformed once, after deadsnakes PPA is added.
jamesoutterside
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.