Dynamic filtering #24
Conversation
…. Use the filter in data fetching methods, allowing customization based on user-selected filter choices. to Improve user interaction and data relevance
…sts add ,dynamic addition of filter fields based on configuration, comprehensive unit tests for robust functionality
…sts add ,dynamic addition of filter fields based on configuration, comprehensive unit tests for robust functionality
dashboards/component/filters.py
Outdated
|
|
||
| return reverse("dashboards:filter_component", args=args) | ||
|
|
||
| def get_filter_form(self) -> Type[FilterSet]: |
There was a problem hiding this comment.
This should probably be get_filterset
dashboards/component/filters.py
Outdated
| model: Optional[Type[models.Model]] = None | ||
| method: Literal["get", "post"] = "get" | ||
| submit_url: Optional[str] = None | ||
| filter_fields: Optional[Dict[str, Any]] = None |
There was a problem hiding this comment.
I wonder if it makes more sense to just store the filter set class here rather than an arbitrary dict, this would mean all fields wouldn't need to be created as CharFilter
There was a problem hiding this comment.
We probably also need to validate that the filter is set and raise a ConfigurationError if not
| class Meta(ModelDataMixin.Meta, PlotlyChartSerializer.Meta): | ||
| pass | ||
| filter_component = Filter # Added the Filter component here |
There was a problem hiding this comment.
I don't think we want to set a default here, it should just be a type annotation and default to None as many use cases wont want a filter on a chart
There was a problem hiding this comment.
It should also be the FilterSet that gets passed into the filter component rather than the filter component itself
dashboards/component/form.py
Outdated
| @@ -77,6 +80,13 @@ def get_form(self, request: HttpRequest = None) -> DashboardForm: | |||
| data = request.GET | |||
|
|
|||
| form = self.form(data=data) | |||
|
|
|||
| # Create and apply the GenericFilter if filter_data and filter_fields are provided | |||
| if self.filter_data and self.filter_fields and self.model: | |||
There was a problem hiding this comment.
I may be misunderstanding something but why are we applying a filter here, the form shouldn't be doing any filtering right? it will just be providing the ability to submit data?
| 1. Import GenericFilter: | ||
|
|
||
|
|
||
| from dashboards.component.filters import GenericFilter |
There was a problem hiding this comment.
Is this out of date? GenericFilter doesn't exist
There was a problem hiding this comment.
updated the documentation it was due to it being implemented this way before
| "USER": self.DATABASE_USER, | ||
| "PASSWORD": self.DATABASE_PASSWORD, | ||
| } | ||
|
|
There was a problem hiding this comment.
It probably makes sense for the demo to use sqlite, just need to make sure we don't have anything running this in the wild
There was a problem hiding this comment.
I have commented out the extra db fields
filter component is now similar to all other components , comprehensive unit tests for robust functionality. unit test similar to all existing unit tests in the code . filter linked with form components .Improve rendering logic for enhanced flexibility