Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the text "Warning" from warning #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prakash-gds
Copy link

The gov uk design system doesn't show the text "Warning" in the Warning text, just the warning text icon and the actual text. This change makes the text "Warning" hidden to make it consistent with govuk design system

Referemce: https://design-system.service.gov.uk/components/warning-text/

The gov uk design system doesn't show the text "Warning" in the
Warning text, just the warning text icon and the actual text.
This change makes the text "Warning" hidden to make it consistent
with govuk design system
@StuartMacKay
Copy link
Collaborator

Thanks for the pull request. The current version supports version 4.8.0 of the govuk design system. With the rapid updates to the 5.x versions since March 1st 2024 we'll need to think of how to track these changes better so it's easy to see which versions are compatible. Most likely the easiest path is simply to keep the same version numbers, so 5.3 of crispy-forms-gds is used with 5.3 of the govuk frontend. We'll merge in your pull request when we start that work (won't be long since we don't want to fall behind).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants