Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be my take for:
Alternative for:
Actually the callback
onPostInstallOrUpdate
should also be renamed into something more descriptive, but anyways.As stated in #252 (comment) there's no need to run an update or any special processing when using
install
.I've tested this in several use-cases: first install, regular install with and without
.lock
file. And it looks good to me so far.Especially the edge-case
install
without.lock
file is handled correctly -> it is treated asupdate
.