Replace data backend and increase flexibility. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 91.48% 92.48% +1.00%
==========================================
Files 19 22 +3
Lines 963 972 +9
==========================================
+ Hits 881 899 +18
+ Misses 82 73 -9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@jspaezp, on second thought, I'll update the docs in a separate PR. This one is large enough 😅 |
jspaezp
reviewed
Sep 29, 2023
jspaezp
reviewed
Oct 4, 2023
jspaezp
reviewed
Oct 9, 2023
jspaezp
reviewed
Oct 9, 2023
| AssertionError | ||
| Indicates that the two dictionaries are not equal. | ||
| """ | ||
| bad_keys = [] |
There was a problem hiding this comment.
I believe this test will not test correctly in both directions (if dict1 is empty but dict2 isnt it will pass)
jspaezp
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrate the data backend for Depthcharge from HDF5 to Apache Arrow-based formats, and updates the API in the process.
Overall this PR simplifies the code base and allows for more flexibility in data parsing and usage for advanced users. Please note that I'm still adding documentation, but the code itself is ready for review.